Hi, is there any possibiluty to fix this without vs-core?
error: package org.valkyrienskies.core.util.datastructures does not exist
import org.valkyrienskies.core.util.datastructures.DenseBlockPosSet;
Hi, is there any possibiluty to fix this without vs-core?
error: package org.valkyrienskies.core.util.datastructures does not exist
import org.valkyrienskies.core.util.datastructures.DenseBlockPosSet;
thx for working out a dupe fix, we’re borrowing the concept for a fixed version of vs
:3dsmile:
Woah! Didnt expect that
🙂 now i want to fix another bug with rftools and VS compatibility, but stuck to this problem with DenseBlockPosSet :с
It might be the same problem I was having when making that fix
yeahh, tech or @getitemfromblock will have a better idea than me on that :thonk: they should be on in a few hours here :thonk:
I am working in UE5 usually and new to java, so it may be problem in my leak of knowledge, I’m assuming the problem is in the absence of the vs-core and datastructures in it
I.E. that it does not compile because the VSCore version that is used here is lacking some stuff
What is the thing you are trying to fix?
Maybe there is a workaround that does not involve adding VSCore as a dependency
i dont know exacly what i should do with this problem, and by using DenseBlockPosSet wanted to test some things, but its bug with rotation of some rftools utility blocks, because as i researched they have specific rotation tags, not just east north etc, but topeast for example
Nbt tags are supposed to be transferred from blocks to blocks when assembling
🤔
this just looks like a problem where you don’t have vs-core added to the dev environment
But it was too hard to try fixing everything
Than to just fix the old code by applying the suggested changes
Anyways I can try to take a look at what’s happening later if I don’t forget about it
I don’t have any code for debugging anymore, but i can name specific blocks that are bugged
Ok so if I understand correctly, its the block state breaking not the nbt, right?
It might be because when copied the blocks receive an update before all stuff is copied, if I remember correctly
dont know, sorry, wanted to test but i cant because of DenseBlockPosSet problem, now i am trying add vscore to project
😅
Fixed! For blocks like redstone_transmitter I made a fix in my submomode, and I will update it on github a bit later : )
If you feel like it, you can consider implementing the fix in Thea’s fork of VS directly via a pull request
:3dsmile:
The idea would be to implement that directly in VS’s ship creation code instead of doing it via a mixin
You can take a look at my latest commit on Thea’s VS fork to see the exact function you should edit
I can do it if you prefer, or tell you more precisely what to do later today
This conversation is on Discord · Reply there