Hello! Recently I have been having an issue where whenever I stand up from my airship, I teleport to the last known location of the helm. Every time I move further than around 60 blocks I am teleported away from my airship. Is there a way I can fix this?
It may have something to do with server lag or ping, because when I played with 4 players it started to happen consistantly, but with 2 players it functioned fine
How do I send a modlist without sending the modpack? Is there a way to copy paste
@brickyboy tried it again with 4 players, same thing. My frames and ping doesn’t change but this mod doesn’t like it when more than 3 players are online
can you get together your 3-4 friends and see if you can cause it with just Valkyrien Skies and Eureka?
They are very stubborn I HIGHLY doubt I can convince them to help me debug it
someone claimed to have fixed it but has not told us how they fixed it (@eminai_the_white pls tell me
🙏 )
Eminai seems somewhat absent right now, sadly, I also wasn’t able to get in touch with him
🙁
I can however confirm that I have not had any teleportation issues since using his version
im back, things have been rough lately. this is the first time ive loaded discord in over a week tbh.
are you talking about my fix with mounted players drifting from a mounted helm when the ship moves?
if i remember the official release of VS2 2.4.11 & Eureka 1.6.3 will not reproduce the bug. but the upstream playtest has a new way of handling the shipyard useRadiusZeroShipChunk… somehting i cant remember.
basically the issue is the seat entity is parked in the shipyard and never moves, so its chunk never reaches entity-ticking range and ChunkMap.tick never calls sendChanges for it. That’s the only thing that broadcasts ClientboundSetPassengersPacket after spawn, and the seat is spawned before the rider mounts, so the one pairing burst everyone nearby receives says the seat is empty. Nobody watching is ever told about the mount, their client has no vehicle for that player, and the ship mount render path can’t engage.
The fix announces it at the seat instead, in addPassenger / removePassenger, where the passenger list actually changes. That covers every seat and every mount path rather than one caller. Seats that do move already worked, they now get one duplicate packet per mount.
I also tried widening the entity-ticking check in ChunkMap.tick for shipyard chunks. That’s the more general fix, but it touches a hot path for every tracked entity every tick and reverses a flag VS2 sets deliberately, so I left it alone.
It’s fine to be left as is I guess. I’m the only one in the server using VS seriously and at this point I’m just annoyed enough to remove it
Being forced to remove VS because of an issue means the issue isn’t fine
:wompwomp:
If you’re willing to still try to fix this issue, there’s an unofficial version of VS that might fix it: https://github.com/Eminai-LeoVinci/VS2/releases
It fixes the waterlogging but not the teleporting issue. I’ll try it
player moves with the helm but when they dismount, they’re back where they started
maybe that was it, its been over 2 months since i worked on this issue. let me build with only the specific fix i mentioned, and see if i can get the bug to reproduce. which i havent seen evidence of it since Eureka Ships 2 and the birth of Armada
yeh now that i think about it i do remember dismounting and ending up behind the ship in mid air
i think i found them all, and its 3 symptoms but only 2 fixes. ive unarchived
my old forks and pushed a branch to each, so theres something to actually look
at before i open anything.
1: in multiplayer, everyone else sees the mounted player drift off the helm and
get left behind, then snap back when they stand up. worth knowing the versions
differ here: on 1.21.11 startRiding hands the rider the passengers packet
directly so their own screen is always right, but on 1.20.1 it doesnt send one
at all, so ServerEntity.sendChanges is the only thing telling anyone. if that
doesnt fire, nobody knows about the mount, rider included
2: mount a helm, travel far enough down, and dismounting triggers fall damage
that sometimes kills you. scales with how far you descended, naturally.
3: sometimes you dismount and youre not on the helm at all, youre anywhere from
a few blocks to chunks behind the moving ship, falling out of the sky. didnt
happen every time but it definitely killed people on survival, including me when
i started the first ports.
2 and 3 look like one bug: the rider’s server position going stale. theres a
branch in LivingEntity.dismountVehicle where if the seat is already removed by
the time you dismount, you get placed at your own server position with
y = max(yours, the seat’s) instead of the seat’s dismount location, so it never
goes through the shipyard world conversion. stale x/z leaves you behind the
ship, stale y gives you the drop. holding the rider on the seat every tick makes
both the normal path and that fallback land in the right spot, so one fix covers
both.
currently both branches have the fix committed, im compiling them now to make
sure they build, then testing in game over LAN.
VS2 fork
branch: https://github.com/Eminai-LeoVinci/Valkyrien-Skies-2/tree/1.20.1/fix-seat-passenger-sync
commit: https://github.com/Eminai-LeoVinci/Valkyrien-Skies-2/commit/082160a3da4f3bfbe38f1101df1f4217626aa26e
Eureka Fork
branch: https://github.com/Eminai-LeoVinci/Eureka/tree/1.20.1/fix-helm-rider-position
commit: https://github.com/ValkyrienSkies/Eureka/commit/eece1915ea1c479be301f3055d5145d8e1c2d62d
also, i was a dumb ass and forgot the second fix never made it onto the Eureka
Ships 2 1.20.1 branch, it only ever existed on my Armada 1.20.1 branch. so if
you went looking for it and came up empty, thats why, sorry! ive ported it fresh
onto upstream for this one along with the VS2 branch.
do these sound right as what youd want PR’d?
yeah, this one:
https://github.com/Eminai-LeoVinci/Eureka/commit/5c74944f2c94926a23a93d3a0a7970f6ef9b5e82
its 24 lines in ShipHelmBlockEntity, a syncSeatedRiders helper plus one call at
the end of the tick that already runs. all it does is take each seat, transforms
its position through the ship, and holds the rider there every tick.
the reason it needs doing at all, the rider’s server position only gets refreshed
while the seat itself is ticked, via rideTick -> positionRider. whenever that
lapses, or the seat is already gone by the time you dismount, LivingEntity
.dismountVehicle takes its fallback branch and puts you at your own position with
y = max(yours, the vehicle’s) instead of the seat’s dismount location. that
fallback never goes through the shipyard to world conversion, so you get dropped
back where you originally mounted instead of on the deck. stale x/z is the “left
behind the ship” one, stale y is the fall damage one.
fair warning if you go digging for the original:
there isnt a clean one. it first went in buried inside a big shitty squashed port commit, so thats useless to read. the link above is a fresh port of it straight onto 1.20.1/main, which is the version
i’d want to PR anyway.
also if i can ask a quick question, since its your call really. i put it in Eureka because
the helm block entity is the thing thats already ticking. but ShipMountingEntity
.positionRider is sitting commented out upstream with a “partial fix, TODO make a
full fix eventually” note, which looks like where you actually wanted this to live.
if youd rather it went in VS2 so it covers anything that mounts a ship seat rather
than just helms, lmk and i can do that. or if you have enough to approch you own way by all means.
is that everything you need?
This conversation is on Discord · Reply there
:clueless:
image.png
image.png
image.png