my server keeps crashing when I’m dismantling a ship with the helm from eureka
can you send the crash report found in the crash-reports folder of your world files
Yeah, that is propulsion. Balloons do not handle disassembly well, so, until it is fixed - just do not disassemble ships with balloons on them :P
unless u cant really remove it cause you got a lot of blocks from it placed n stuff
there were few blocks, and I noticed that this happens when the propulsion ball is filled with gas and is flying
NullPointerException: Cannot invoke “org.joml.primitives.AABBic.minX()” because “shipAABB” is null
at com.deltasf.createpropulsion.balloons.utils.RLEVolume.isInside(RLEVolume.java:23)
if (ship != null) {
return rleVolume.isInside(pos.getX(), pos.getY(), pos.getZ(), groupAABB, ship.getShipAABB());
} else {
return true;
}
From stacktrace it seems like balloon event resolution is called (because literally all envelopes got moved due to disassembly). So it should be called on the tick after the disassembly and therefore ship should be null but it isn’t for some reason?
This is like the hottest path in the whole mod though
😭
Can’t afford an additional check here without making all scans 20% slower
But what I can do is just not process balloon events if they are not in the shipyard, which should fix the issue
:3dsmile:
I mean, RLEVolume.isInside is called for every single queued block during any kind of volume scans. So it is potentially called hundreds of thousands of times per single tick. I guess a single check (even if always branch predicted correctly) would add to the scan duration
And on top of that there is a much simpler solution that solves the issue on the higher level and has zero performance impact :P
This conversation is on Discord · Reply there